Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to resources made outside of Terraform are not detected #225

Open
michaelbuemi opened this issue Oct 16, 2023 · 5 comments
Open

Comments

@michaelbuemi
Copy link

michaelbuemi commented Oct 16, 2023

I've tested both volterra_ip_prefix_set and volterra_origin_pool. Making a change to the description will be detected, but not if I change an IP in the prefix set or the origin servers.

For example, I've changed this origin IP from 192.0.2.24 to 192.0.2.25.

foo-dev-origins

Here is the state in our TF Enterprise:

foo-dev-origins-state

And here is the terraform plan run, where the only detected modification is the description on the prefix set. (Which was in fact a change, just not the ONLY change ... )

module.foo-dev.volterra_certificate_chain.entrust-chain: Refreshing state... [id=2f5eb8b3-b74d-46e1-81d8-4d764a7a16da]
module.foo-dev.volterra_namespace.ns: Refreshing state... [id=0cd411cd-098e-4067-99ba-2fe3d3eabefb]
module.foo-dev.volterra_origin_pool.foo-dev-origin: Refreshing state... [id=49ba25d3-d71e-4bda-bd9e-a647d9115d8a]
module.foo-dev.volterra_ip_prefix_set.allow-list: Refreshing state... [id=b3494b09-8722-4829-b660-bab194d12379]
2023-10-16T14:31:22.813Z [WARN]  Provider "registry.terraform.io/volterraedge/volterra" produced an unexpected new value for module.foo-dev.volterra_ip_prefix_set.allow-list during refresh.
      - .description: was cty.StringVal("Example allow list."), but now cty.StringVal("Example deny list.")
module.foo-prod.volterra_ip_prefix_set.allow-list: Refreshing state... [id=8e5e6c4a-094d-4a4e-8359-ac0937f7c304]
module.foo-dev.volterra_ip_prefix_set.allow-list: Drift detected (update)

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.foo-dev.volterra_ip_prefix_set.allow-list will be updated in-place
  ~ resource "volterra_ip_prefix_set" "allow-list" {
      ~ description = "Example deny list." -> "Example allow list."
        id          = "b3494b09-8722-4829-b660-bab194d12379"
        name        = "allow-list"
        # (5 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
@michaelbuemi
Copy link
Author

This is probably the same issue as reported in #126 (comment)

@megamattzilla
Copy link

I can replicate this with resource volterra_tcp_loadbalancer. I can change the load balancers port in the portal to something totally different but when I rerun terraform it does not detect any changes.

@abhinavgrover15
Copy link
Collaborator

@megamattzilla Drift will be supported for below selected resources in upcoming release.

  1. TCP Load Balancer
  2. HTTP Load Balancer
  3. Origin Pools
  4. Service Policy
  5. IP Prefix Set.

Thank you for your patience and co-operation.

@megamattzilla
Copy link

Thats great news, thanks for the update!!

@eissko
Copy link

eissko commented Apr 25, 2024

@abhinavgrover15 thanks for heads-up. I was just about to create an issue that active service policy drift is not detected. I understand based on your comment this will be implemented. do you know which release version is this fix targeted to? thanks. Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants