Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

在front-matter中设置comments: false无效 #370

Closed
2 tasks done
Colsrch opened this issue Jul 15, 2020 · 6 comments
Closed
2 tasks done

在front-matter中设置comments: false无效 #370

Colsrch opened this issue Jul 15, 2020 · 6 comments

Comments

@Colsrch
Copy link
Member

Colsrch commented Jul 15, 2020

BUG描述

复现报告

分类:反馈一个明确的BUG

  • 将主题升级至最新版本。
  • 下载主题官网源码运行,经过一定的步骤,可以复现此BUG。

复现步骤

  1. xxx
  2. xxx
  3. xxx

环境信息

复现地址:

截图:

浏览器、操作系统

站点配置文件

主题配置文件

更多信息

node.js & npm


package.json


如图,在front-matter中设置comments: false后,设置页依旧会显示评论。

我看到前面 @inkss 也提出了这个问题,不知道什么时候解决呢。

话说我用Pjax2分支用的好好的,换来最新版后,虽然解决了以前的一些问题,但又多了一堆问题😂

@Colsrch Colsrch added the bug-report 反馈一个 BUG label Jul 15, 2020
@MHuiG
Copy link
Member

MHuiG commented Jul 16, 2020

body: [article] 仍然有效

#358

@MHuiG MHuiG removed the bug-report 反馈一个 BUG label Jul 16, 2020
@Colsrch
Copy link
Member Author

Colsrch commented Jul 16, 2020

body: [article] 仍然有效

#358

我看了,知道这个还有效,但总不能不修复comments这个吧。🙄

@xaoxuu
Copy link
Member

xaoxuu commented Jul 16, 2020

那不如把这个 comments: false 删掉算了

@Colsrch
Copy link
Member Author

Colsrch commented Jul 16, 2020

我怀疑你想偷懒

@inkss
Copy link
Member

inkss commented Jul 16, 2020

@xaoxuu 有不少啊

image

@MHuiG
Copy link
Member

MHuiG commented Jul 16, 2020

<% if (theme.comments.service && theme.comments.service.length > 0) { %>

<% if (page.comments && theme.comments.service && theme.comments.service.length > 0) { %>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants