Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions: some tests before building docker images #220

Open
vogler opened this issue Sep 22, 2023 · 0 comments
Open

GitHub Actions: some tests before building docker images #220

vogler opened this issue Sep 22, 2023 · 0 comments
Labels
optimization

Comments

@vogler
Copy link
Owner

vogler commented Sep 22, 2023

Before we spent ~10min building a multi-platform docker image, we should run some basic tests.

  • npm ci - can result be used for building the docker image?
  • not sure what to test
    • at least launching firefox
    • check that not logged in
    • add env vars and check that games are available?
@vogler vogler added feature New feature or request optimization and removed feature New feature or request labels Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vogler