Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: include nonce in SIKTx #1118

Open
lucasmenendez opened this issue Sep 26, 2023 · 1 comment · May be fixed by #1133
Open

bug: include nonce in SIKTx #1118

lucasmenendez opened this issue Sep 26, 2023 · 1 comment · May be fixed by #1133
Assignees
@lucasmenendez @marcvelmer
Labels
bug Something isn't working

Comments

@lucasmenendez
Copy link
Contributor

The SIKTx does not include a nonce, and it must have. The change will be breaking for the sdk because the protobuf model is going to be updated (here).
@lucasmenendez lucasmenendez added the bug Something isn't working label Sep 26, 2023
This was referenced Oct 5, 2023
Merged
Draft
@lucasmenendez lucasmenendez linked a pull request Oct 5, 2023 that will close this issue
Bug/include nonce in siktx #1133
Draft
@jpaulet jpaulet closed this as completed Jan 2, 2024
@jpaulet jpaulet reopened this Jan 2, 2024
@jpaulet
Copy link
Member

jpaulet commented Jan 2, 2024

@marcvelmer is this implemented also in the SDK?

@jpaulet jpaulet closed this as completed Feb 20, 2024
@jpaulet jpaulet reopened this Feb 20, 2024
This was referenced Feb 20, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasmenendez lucasmenendez

@marcvelmer marcvelmer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug/include nonce in siktx vocdoni/vocdoni-node
3 participants
@jpaulet @lucasmenendez @marcvelmer