Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG/CLN: FeatureExtractor should not be making Features instances #146

Open
Tracked by #66
NickleDave opened this issue May 16, 2024 · 0 comments
Open
Tracked by #66

BUG/CLN: FeatureExtractor should not be making Features instances #146

NickleDave opened this issue May 16, 2024 · 0 comments

Comments

@NickleDave
Copy link
Contributor

NickleDave commented May 16, 2024 •
edited

it should instead assume it gets Features from the callback already

Can we validate that the callback returns features in the init somehow?
@NickleDave NickleDave changed the title BUG/CLN: FeatureExtractor should not be "making" features BUG/CLN: FeatureExtractor should not be making Features instances May 16, 2024
@NickleDave NickleDave mentioned this issue May 23, 2024
Open
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NickleDave