Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add 'sat-multitaper' as method for vocalpy.spectrogram #136

Open
NickleDave opened this issue Apr 3, 2024 · 2 comments
Open

ENH: Add 'sat-multitaper' as method for vocalpy.spectrogram #136

NickleDave opened this issue Apr 3, 2024 · 2 comments
Labels
ENH: enhancement New feature or request Spectral Issues related to the spectral module and spectral representations Spectrogram issues related to vocalpy.Spectrogram or spectrograms in general

Comments

@NickleDave
Copy link
Contributor

More general name, less awkward, makes sense when we refer to other time-freq-reps, e.g. tf replacement, gammatone, et al.

@NickleDave NickleDave added ENH: enhancement New feature or request Spectrogram issues related to vocalpy.Spectrogram or spectrograms in general Spectral Issues related to the spectral module and spectral representations labels Apr 3, 2024
@NickleDave
Copy link
Contributor Author

NickleDave commented Apr 9, 2024

Thinking about this more ...
Spectrogram is common enough that I think we don't want to change it.
Even other time-freq representations we use or will want to use are still (power) spectrograms: SAT uses a multi-taper spectrogram, soundsig/biosound uses a Gaussian window spectrogram. Even time-frequency replacement, as most widely used, still ends up giving you a power spectrogram, IIUC

Other things I will need to add presently are better described as features, e.g. gammatone

So: wontfix, for now

But what I think we should do is separate out the multi-taper spectral representation used by SAT and make it possible to call that as a spectrogram

@NickleDave
Copy link
Contributor Author

I still don't like the name SpectrogramMaker but if most of what we use is a spectrogram then makes sense to keep it

@NickleDave NickleDave changed the title ENH: Rename spectrogram/Spectrogram/SpectrogramMaker -> time_freq_repr / TimeFreqRepr / TimeFreqTransformer ENH: Add 'sat-multitaper' as method for vocalpy.spectrogram Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENH: enhancement New feature or request Spectral Issues related to the spectral module and spectral representations Spectrogram issues related to vocalpy.Spectrogram or spectrograms in general
Projects
None yet
Development

No branches or pull requests

1 participant