Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TagsService is Missing 3 Methods #270

Closed
SimonSparksUK opened this issue May 13, 2024 · 1 comment
Closed

TagsService is Missing 3 Methods #270

SimonSparksUK opened this issue May 13, 2024 · 1 comment

Comments

@SimonSparksUK
Copy link

Description

On Aria Automation v8.16 when browsing the swagger at the following URL

/iaas-api/swagger/webjars/swagger-ui/index.html#/Tags

there are 4 functions available as you can see in this screenshot

image

however in the typescript class there is only 1 function as you can see in this screenshot

image

Please create the 3 missing functions in the typescript class

@VenelinBakalov
Copy link
Contributor

VenelinBakalov commented May 30, 2024

Hi Simon,

Thanks for raising your concern. Unfortunately, the issue you are describing is not related to Build Tools for Aria directly. This seems to be coming from interfaces/types defined in custom code (vRO package). While the package itself might be using Build Tools for Aria in order to transpile it (build the custom code into a vRO pakcage), the missing interfaces are coming from the code base of that package and not from Build Tools for VMware Aria. On first glance, I would assume that the package you are referring to has been created against an earlier version of vRA and the missing properties you are describing are most likely coming from a later version of vRA.

However, I can propose to you an easy alternative solution which you can implement in your own code base. You can use native TS inheritance to create your own class that extends and re-uses everything from that package's class and add the new functions on top.

Here is an example of how this can work by defining your own type: "CustomTagsService":

export class CustomTagsService extends TagsService {
    constructor(httpClient: HttpClient) {
        super(httpClient);
    }

    public createTag(....) {.....};
    public deleteTag(....) {.....};
}

After that you can use your own defined CustomTagsService which preserves all of the original fields and adds the missing one on top and if needed at later point - you can continue to extend it.

I hope this helps to solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants