Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

property-group is imported with scope of shared project but no way of a global scope #250

Open
mdittbrenner215 opened this issue Mar 29, 2024 · 6 comments
Assignees
Labels
artifact-manager bug Something isn't working java Pull requests that update Java code

Comments

@mdittbrenner215
Copy link

Description

property-group is imported with scope of shared project but no way of a global scope

Steps to Reproduce

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Preconditions: [What are the preconditions to reproduce the issue]

Expected behavior:
Have a way to import a global scope property group.

Actual behavior:
It imports only to the share project.
Worse part cant delete because its attached to a version blueprint which was released

Reproduces how often: 100%

Component/s: [What are the Build Tools for VMware Aria components affected by the issue (e.g. "common/artifact-manager", "maven/plugins/vra-ng", "typescript/vrotest", etc)]
vra-ng

propertyGroup.setProjectIdInRawData(this.projectId);

in VraNgPropertyGroupStore.java

Affects Build/s: [Which are the Build Tools for VMware Aria releases / builds affected by the issue]

Environment

Client

  • Build Tools for VMware Aria Version:
  • Visual Studio Code Version:
  • OS Version:

Server

  • vRealize Automation Version:
  • vRealize Orchestrator Version:
  • vRealize Operations Version:
  • vRealize Log Insight Version:

Failure Logs

Related issues and PRs

Additional Context

@SimonSparksUK
Copy link

This is currently affecting us

Copy link

github-actions bot commented May 4, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 4, 2024
@mdittbrenner215
Copy link
Author

Please remove the stale tag as it hasnt been looked at by VMware yet

@github-actions github-actions bot removed the Stale label May 7, 2024
@SimonSparksUK
Copy link

Nudge

@Michaelpalacce
Copy link
Contributor

Michaelpalacce commented May 29, 2024

Can confirm this is a BUG.

I believe pushing a property group without a projectId will make it global, as it works with other resources (needs to be verified).

Two places where logic needs to be changed in the VraNgPropertyGroupStore is:

  • image
    • Here we need to modify this so we don't delete the projectId
  • image
    • Here we need to set the projectId ONLY if it already exists as we do in other places

@SimonSparksUK, @mdittbrenner215 Do you think you can create a quick PR and test this one out? Otherwise feel free to take a look at https://github.com/vmware/build-tools-for-vmware-aria/blob/main/SUPPORT.md#support

@Michaelpalacce Michaelpalacce added bug Something isn't working java Pull requests that update Java code artifact-manager labels May 29, 2024
@mdittbrenner215
Copy link
Author

I know when we push content all of our content we use a projectid. For example that gets used for import blueprints and cataloig items which i believe needs that projectid.

Since we have that in place it auto puts the projectid in for the property groups.
So in our case we would need to have a global property group but be able to import others.

@Tchoui Tchoui self-assigned this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact-manager bug Something isn't working java Pull requests that update Java code
Projects
None yet
Development

No branches or pull requests

4 participants