Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to new TS version #215

Open
VenelinBakalov opened this issue Jan 5, 2024 · 5 comments
Open

Upgrade to new TS version #215

VenelinBakalov opened this issue Jan 5, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@VenelinBakalov
Copy link
Contributor

Description

Original request: vmware/vrealize-developer-tools#132

From time to time I find myself writing sound typescript code only to be stumped when building the project.

As I understand it the vrotsc is based on a much older typescript version than the one included in VS Code.
In VS Code I have now version 5.1.3

and when looking at the vrotsc code it seems to be based of version 3.8.3

Would it be possible to present this infomation or perhaps download the correct version in order for the Intellisense to match the transpile step?

Example

Today I tried to use Template literal types.

With the default typescript in vscode
image

All seems well until I build the project and it fails with.
image

But if I manually install and use typescript version 3.8.3
The Intellisense shows it is not valid.
image

@Michaelpalacce Michaelpalacce added the enhancement New feature or request label Jan 10, 2024
@Rehiq Rehiq self-assigned this Feb 5, 2024
@Rehiq Rehiq linked a pull request Mar 1, 2024 that will close this issue
Copy link

github-actions bot commented Mar 7, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 7, 2024
@VenelinBakalov
Copy link
Contributor Author

Issue is not stale, currently there is a related PR opened: #245

@github-actions github-actions bot removed the Stale label Mar 8, 2024
Copy link

github-actions bot commented Apr 7, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 7, 2024
@VenelinBakalov
Copy link
Contributor Author

Still in progress

@github-actions github-actions bot removed the Stale label Apr 9, 2024
@github-actions github-actions bot added the Stale label May 9, 2024
@Michaelpalacce Michaelpalacce added this to the 3.0.0 milestone May 23, 2024
@pe1pip
Copy link
Contributor

pe1pip commented May 30, 2024

This would be nice... we're working towards improving our unit testing by leveraging yest, and the newer TSC could help

@vmware vmware deleted a comment from github-actions bot May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants