Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Template folder name is used when validating if the record exists on the server, but the name in the details.json is used when creating/updating #210

Open
Michaelpalacce opened this issue Jan 4, 2024 · 5 comments
Assignees
Labels
artifact-manager bug Something isn't working

Comments

@Michaelpalacce
Copy link
Contributor

Description

Perhaps we can think of a structure where only one or the other is used as a source of truth. A good option would be to only use the folder name and add it to the details.json.

It would be beneficial if we take a similar approach to other resources to unify the logic as much as possible?

Alternatives

An alternative solution would be to use the details.json, however that will conflict with how the resources are exported.

Additional Context

N/A

@Michaelpalacce
Copy link
Contributor Author

We can submit a bugfix to use the information in the details.json exclusively, as well as add a quick check if the 2 are the same and fail if the details.json and the folder name are not the same.

@Nikson998 Nikson998 self-assigned this Jan 8, 2024
@Michaelpalacce Michaelpalacce added bug Something isn't working artifact-manager labels Jan 10, 2024
@Michaelpalacce
Copy link
Contributor Author

@Nikson998 What is the progress on this one?

@Nikson998
Copy link

Nikson998 commented Feb 1, 2024 via email

Copy link

github-actions bot commented Mar 3, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 3, 2024
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 10, 2024
@vmware vmware locked and limited conversation to collaborators Mar 11, 2024
@Michaelpalacce Michaelpalacce converted this issue into a discussion Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
artifact-manager bug Something isn't working
Projects
None yet
2 participants