Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #207 #218

Closed
wants to merge 1 commit into from
Closed

Fixed #207 #218

wants to merge 1 commit into from

Conversation

emanelsayed39
Copy link

Description

I found a bug in the code that import image mapping from the wrong region directory
fixed by make sure to import the image mapping from the corresponding region directory

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated CHANGELOG.md with a short summary of the changes introduced
  • [ x] I have tested against live environment, if applicable
  • I have added relevant usage information (As-built)
  • Any structure and/or content vRA-NG improvements are synchronized with vra-ng and ts-vra-ng archetypes
  • Every new or updated Installer property is documented in docs/archive/doc/markdown/use-bundle-installer.md
  • Dependencies in pom.xml are up-to-date
  • [ x] My changes have been rebased and squashed to the minimal number of relevant commits
  • [x ] My changes have a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

I tested the changes on my environment.

Release Notes

Related issues and PRs

@emanelsayed39 emanelsayed39 requested a review from a team as a code owner January 11, 2024 07:52
@emanelsayed39 emanelsayed39 linked an issue Jan 11, 2024 that may be closed by this pull request
Last Region image mapping overwrites the value for all other regions. #207
Open
@vmwclabot
Copy link
Member

@emanelsayed39, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@emanelsayed39, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@VenelinBakalov
Copy link
Contributor

Hi @emanelsayed39 , thanks for your contribution!
Could I ask you to add a short summary of the issue fixes/previous and new behaviour inside the CHANGELOG.md and Release.md files?
Here are some samples from other PRs but you can also check directly the files from the previous versions:

@Michaelpalacce
Copy link
Contributor

Closing this after a discussion with @emanelsayed39 there is more nuance to this

@Michaelpalacce
Copy link
Contributor

Also @emanelsayed39 make sure to follow the guide I sent you to resolve the issues regarding the dco-required label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Last Region image mapping overwrites the value for all other regions.
4 participants
@emanelsayed39 @vmwclabot @VenelinBakalov @Michaelpalacce