New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot install velero with go get + go install #2966
Comments
Thanks for this - I was able to replicate the issue. In general, our supported delivery methods are via the GitHub releases, and there is a Linux client available. I'll file this as a bug though, as our dependency tree should resolve correctly via |
It looks like we may have to update to external-snapshotter v3 for better Go modules support, but I'm not 100% sure. |
I think this will still be an issue in the new version 😞 v3.0.0 still relies on the Kubernetes repo which doesn't support being used as a library. It looks like the folks working/relying on external-snapshotter have been trying to get the parts that the project relies on to be usable outside of that repo (kubernetes/kubernetes#85692 , kubernetes/kubernetes#85693) It looks like there are some workarounds which we could propose to that project. |
I looked at this a bit more, and the external-snapshotter project actually created a separate go module for the client and APIs which doesn't have the dependency on k/k and using it fixes the problem here. This new go module is available in v2.2.0-rc3, so we wouldn't have to upgrade the API types to v3 but updating to that newer RC means that we pull in v0.19.0-rc2 versions of some of the Kubernetes modules. v3 of the module uses the GA release of the Kubernetes modules: v0.19.0. Either way, to fix this we're going to have to do some upgrading of the Kubernetes modules we're using. |
@georgettica Thanks! I think we'll need to move this to v1.5.3 or v1.6.0 because v1.5.2 is going to get cut this week. |
Well, this doesn't affect installing Velero CLI alone but also any plug-ins that import Velero code. Maybe I'll just wait before polluting my |
@pires Unfortunately, those |
Hey @georgettica, do you have bandwidth to tackle this for our v1.6 release? |
I will do my best and will consult when necessary. |
How to solve this problem before 1.6 is released |
I am having trouble fixing the issue, tried to tackle from multiple angles and to no avail :( I will upload a PR with a failing test and I hope you could guide me to a suceeding build |
+1 while trying to compile a velero plugin:
|
@brito-rafa it's still being worked on in #3202 |
I'm running into this, is there any workarounds to make it compile with v1.5.x? @georgettica |
Once my PR is merged yes, but so far I am not done on it so it will take a while longer. If someone wiser than me has a quick fix, feel free to.speak up |
I used the following workaround on my go.mod (as pointed in a previous comment by @pires ): I added all these "replace" directives as specified on this file. |
@brito-rafa thank you, that worked perfectly! I'll remove those when it's fixed upstream. Cheers. |
…napshotter-version Georgettica/bump external snapshotter version (fixes #2966)
What steps did you take and what happened:
What did you expect to happen:
that the velero cli will be installed successfully
Environment:
running inside a fedora container with go installed
/etc/os-release
):Vote on this issue!
This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.
The text was updated successfully, but these errors were encountered: