Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Header/Footer comments land in wrong places sometimes when injected into a YAML document #70

Open
ahuffman opened this issue Jun 2, 2021 · 0 comments
Labels
enhancement New feature or request v0.9.0

Comments

@ahuffman
Copy link
Contributor

ahuffman commented Jun 2, 2021

During injection of header/footer comments, they do not always land where they "should" within the YAML document.

This is due to an issue in upstream go library yaml.v3. The problem is essentially an issue with how/where to handle comments in maps.

The headers will land below the target injection point, and the footers can end up sometimes above the target injection point.

We should make an effort to contribute to the upstream library to solve the problem within the library.

Related to:
go-yaml/yaml#610
go-yaml/yaml#695

@ahuffman ahuffman added enhancement New feature or request and removed defect labels Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request v0.9.0
Projects
None yet
Development

No branches or pull requests

1 participant