Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whisper support #180

Open
gottlike opened this issue Jun 21, 2023 · 27 comments
Open

Whisper support #180

gottlike opened this issue Jun 21, 2023 · 27 comments
Labels
new model Requests to new models

Comments

@gottlike
Copy link
Contributor

gottlike commented Jun 21, 2023

Is support for Whisper on the roadmap? Something like https://github.com/ggerganov/whisper.cpp would be great.

@WoosukKwon WoosukKwon added the new model Requests to new models label Jun 21, 2023
@zhuohan123
Copy link
Collaborator

Supporting encoder-decoder models is in our roadmap as mentioned in #187. Feel free to join the discussion and potentially contribute!

@libratiger
Copy link

+1 for this feature

@silvacarl2
Copy link

+2 for this feature

@xtqxk
Copy link

xtqxk commented Oct 24, 2023

+3 for this feature

@arun2728
Copy link

arun2728 commented Dec 1, 2023

+4 for this feature

@SinanAkkoyun
Copy link

+555

@Swiffers
Copy link

Swiffers commented Jan 2, 2024

+1

@hahazei
Copy link

hahazei commented Feb 26, 2024

+1

@binarycrayon
Copy link

monitoring

@afeldman-nm
Copy link
Contributor

@zhuohan123 I am working on Whisper support.

@silvacarl2
Copy link

NO WAY!!!!!!!!!!!!!!!!!!! THAT WILL BE AWESOME!!!!!!!!!!!!!!!!!!!!!

@libratiger
Copy link

I am working on this PR, and will soon submit the draft.

@silvacarl2
Copy link

THIS IS GOING TO BE HUGE, THX!

@dbogunowicz
Copy link

dbogunowicz commented Mar 12, 2024

Hey @libratiger, together with @afeldman-nm I am now working full-time on the same target. Would you like to sync? It would be more efficient to share knowledge, rather than develop the same thing in two silos.

@libratiger
Copy link

You're right. I've just discovered a discussion about T5 #187 (comment) , where there are differing opinions on the encoder-decoder model. Perhaps it will improve after that PR is merged?

@dbogunowicz
Copy link

@libratiger the current status is as follows: neural magic has finalized the original T5 PR, and we are now benchmarking the solution. In parallel, we are also developing support for Whisperer.

@JackZeng
Copy link

@dbogunowicz any update on this issue? looking forward

@dbogunowicz
Copy link

Hi! I am working on the Whisper on our team fork: neuralmagic#147
The status is: I am running the inference (both prompt prefill as well as autoregressive inference), but I get correctness issues, most likely caused by the erroneous attention mask implementation.

@junior-zsy
Copy link

@dbogunowicz I ran the feature/demian/Whisper branch to run the Whisper model and found an error message: vllm/worker/model_runner. py, line 477, in prepare_decode
Multi_modeal_input)
NameError: name 'multi_modal_input' is not defined, code execution cannot start

@dbogunowicz
Copy link

@junior-zsy fixed for now. Please remember, that we are still working on that PR, so it's pretty much in WiP state. Let me explicitly set the appropriate PR flag.

@junior-zsy
Copy link

@dbogunowicz Ok, thank you. Hope it can be used soon

@silvacarl2
Copy link

same here, this is going to be really cool!

@afeldman-nm
Copy link
Contributor

afeldman-nm commented Apr 3, 2024

@dbogunowicz thanks for your work on Whisper! Since there is clearly interest in this feature and its completion timeline, I want to add the context that Whisper support takes a dependency on encoder/decoder support -

Issue: #187
PR: #3117

which is also WIP (currently works partially but is not quite complete.) I expect to complete encoder/decoder support soon. JFYI for anyone interested in timelines.

@dwoodworth90
Copy link

+1

@afeldman-nm
Copy link
Contributor

afeldman-nm commented Apr 30, 2024

See the encoder/decoder support issue (#187) and new PR (#4289) for a status update on encoder/decoder support, which is a prereq for Whisper support.

@twicer-is-coder
Copy link

Hi, any update on serving faster-whisper via VLLM?

@afeldman-nm
Copy link
Contributor

Hi, any update on serving faster-whisper via VLLM?

Hi @twicer-is-coder ,

Whisper (or any variant thereof) is high of the list of models to add once infrastructure support is in; you can see the roadmap for infrastructure support in this PR:

#4942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new model Requests to new models
Projects
None yet
Development

No branches or pull requests