Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added completion script for Cloud Foundry CLI #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkoper
Copy link

@dkoper dkoper commented Feb 25, 2017

Fixes #78

@codecov-io
Copy link

codecov-io commented Feb 25, 2017

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #80   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          56     56           
=====================================
  Hits           56     56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c288656...87086ba. Read the comment docs.

@chrisant996
Copy link
Collaborator

I would like include this, but it has a dangerous problem:

It runs the entire command line on every completion, including other commands in the command line:
del * & cf Tab will actually run both the del * and the cf command.

This can be partially mitigated by using clink.parseline() and using only the last line_state.

But that's not sufficient, either -- for example:
>foo cf Tab will run the command and redirect output to foo.

To be able to include this, the argmatcher would need to be more discriminating about what it runs. For example, it could use Responding to Arguments in Argmatchers and user_data to collect the words that are relevant to the cf command itself, and run only cf with those arguments.

@chrisant996 chrisant996 added blocked Cannot continue until something is resolved help wanted labels Aug 18, 2022
@chrisant996 chrisant996 force-pushed the master branch 2 times, most recently from 91a0941 to 29ee37e Compare May 15, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Cannot continue until something is resolved help wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add completions for Cloud Foundry CLI
3 participants