Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrays do not use strict comparison #113

Open
X455u opened this issue Jul 31, 2013 · 0 comments
Open

Arrays do not use strict comparison #113

X455u opened this issue Jul 31, 2013 · 0 comments

Comments

@X455u
Copy link
Contributor

X455u commented Jul 31, 2013

The arrays' equal function does not use strict (===) comparison when comparing structures. This could cause problems for instance when comparing values 0 and "".

Currently, arrays that are initialized with a DOM/jQuery element will always get data-value-type="string", which means that JSAV grading will work although the values in the array of the model solution would have data-value-type="number". (check: examples/simple-exercise.html)

Trees on the other hand use strict comparison, when comparing nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant