Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't push untested changes to master #7

Open
ksamuel opened this issue Mar 22, 2018 · 0 comments
Open

Don't push untested changes to master #7

ksamuel opened this issue Mar 22, 2018 · 0 comments

Comments

@ksamuel
Copy link

ksamuel commented Mar 22, 2018

I made a PR for the a typo in the last commit that was crashing the sentinel. See: #6

However, the official tutorial to install the sentinel for the masternode uses the master branch, so if you break it, you break all new installs and update.

Create a dev branch, and work on this separately until you are sure the sentinel is working properly, at which moment you can merge it into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant