Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support other shapes #28

Open
GXSZone opened this issue Jan 2, 2023 · 4 comments
Open

Support other shapes #28

GXSZone opened this issue Jan 2, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@GXSZone
Copy link

GXSZone commented Jan 2, 2023

No description provided.

@GXSZone GXSZone added the bug Something isn't working label Jan 2, 2023
@vitorhugods
Copy link
Owner

vitorhugods commented Jan 2, 2023 •
edited

@GXSZone could you please clarify?

What's the current behaviour, what's desired?

@GXSZone
Copy link
Author

GXSZone commented Jan 2, 2023

@GXSZone could you please clarify?

What's the current behaviour, what's desired?

If the head portrait is a rounded rectangle, the border should be changed to a rounded rectangle

image

@vitorhugods vitorhugods changed the title Develop an interaction suitable for rounded rectangles Support other shapes Jan 2, 2023
@vitorhugods
Copy link
Owner

This is a big task. Everything inside the AvatarView expects a circle and draws it like a circle.

I have no plans in working on this for the moment.

I want to give it a go on remaking this library using Compose and allowing for different shapes and effects. But I haven't actually put any effort into it yet.

For the moment, if you do not need animations, check out GetStream/avatarview-android, as that should work as you expect.

@GXSZone
Copy link
Author

GXSZone commented Jan 2, 2023 •
edited

This is a big task. Everything inside the AvatarView expects a circle and draws it like a circle.

I have no plans in working on this for the moment.

I want to give it a go on remaking this library using Compose and allowing for different shapes and effects. But I haven't actually put any effort into it yet.

For the moment, if you do not need animations, check out GetStream/avatarview-android, as that should work as you expect.

Thank you. I will keep watching because it is really beautiful

@vitorhugods vitorhugods added enhancement New feature or request and removed bug Something isn't working labels Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitorhugods @GXSZone