Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hooks in bench API #5075

Open
4 tasks done
adriencaccia opened this issue Jan 30, 2024 · 0 comments · May be fixed by #5076
Open
4 tasks done

Support hooks in bench API #5075

adriencaccia opened this issue Jan 30, 2024 · 0 comments · May be fixed by #5076
Labels
enhancement New feature or request feat: benchmark Issues and PRs related to the benchmark feature p2-nice-to-have Not breaking anything but nice to have (priority)

Comments

@adriencaccia
Copy link
Contributor

Clear and concise description of the problem

beforeAll, afterAll, beforeEach and afterEach are not run when using vitest bench

Suggested solution

Support them in the benchmark runner

Alternative

No response

Additional context

No response

Validations
adriencaccia added a commit to adriencaccia/vitest that referenced this issue Jan 30, 2024
@adriencaccia
feat(vitest): support hooks in bench runner
b807000 
Fix vitest-dev#5075
@adriencaccia adriencaccia linked a pull request Jan 30, 2024 that will close this issue
Draft
@sheremet-va sheremet-va added enhancement New feature or request feat: benchmark Issues and PRs related to the benchmark feature p2-nice-to-have Not breaking anything but nice to have (priority) labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feat: benchmark Issues and PRs related to the benchmark feature p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(vitest): support hooks in bench runner adriencaccia/vitest
2 participants
@sheremet-va @adriencaccia