Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle Foreign Data Wrapper plugin #592

Open
emccormickva opened this issue Mar 1, 2024 · 3 comments
Open

Oracle Foreign Data Wrapper plugin #592

emccormickva opened this issue Mar 1, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@emccormickva
Copy link

Hi all,

I recently had a client request to install the Oracle FDW plugin on their Postgresql cluster which is deployed and maintained with this wonderful set of playbooks. I wrote a playbook to handle this for them and merged it into their local fork of this repo.

Currently, it only supports EL9 and Oracle Instantclient 19.19 as that is what the customer is running, but is otherwise using and extending variables and structure already in tree here. If I were to extend it to support all of the other distros / versions supported here and add some variables for users to configure oracle client versions, would this be of interest to anyone? I'm not sure how much of an edge case this is, so I wanted to ask before putting the work in.

Cheers,
Erik

@vitabaks
Copy link
Owner

vitabaks commented Mar 2, 2024

Hi @emccormickva

I think it makes sense, but it should be an option and not a default setting. See an example of how I implement this for a future version ("Extension Auto-Setup") - #464

example of a variable name: enable_oracle_fdw

@emccormickva
Copy link
Author

Great. I'll work on cleaning it up and extending it to other distros. I did set it up as optional from the start

roles:
- role: oracle-fdw
when: install_oracle_fdw|bool

I'll switch it to "enable_oracle_fdw" for consistency.

@vitabaks
Copy link
Owner

vitabaks commented Mar 8, 2024

I chose enable instead of install because we not only install packages, but also automatically prepare the configuration if necessary.

@vitabaks vitabaks added the good first issue Good for newcomers label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants