Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public key with 0 at beginning can't be handled by Nostr Console #16

Open
vishalxl opened this issue Nov 7, 2022 · 3 comments
Open
Labels
bug Something isn't working

Comments

@vishalxl
Copy link
Owner

vishalxl commented Nov 7, 2022

If a private key generates a public that has 0's at the beginning, the application does not generate the correct signature or hash, with the result that such accounts can't really work with this application right now.

On sending a kind 1 post, this account's event will be invalid and will be rejected by relays.

On creating an encrypted room by such account, the application crashes.

An example private/public key pair is is c39a51b254c6d0ee022083c271afb4bba3e9ac8b004b7577200f31d6f44d96ef / 000006ed14c0337a42e434cf926252bc77b8788b58d78e8be43f416a43ea771a

originally reported by Sabah.

@vishalxl
Copy link
Owner Author

vishalxl commented Nov 7, 2022

@vishalxl vishalxl added the bug Something isn't working label Nov 10, 2022
@vishalxl
Copy link
Owner Author

vishalxl commented Nov 19, 2022

With recent commit, it does not crash. It can read its inbox or dm sent to it, but can't send dm.

Astral can send a dm using this account. This account on console can read that dm. but it still can't send a dm.

problem is likely in dart340 package's sign() function. It seems to be creating wrong signature.

@vishalxl
Copy link
Owner Author

Same status as above with release 0.1.5-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant