Error with Custom Primitive Layer in ObservableHQ notebook with v9.0.11 vs 8.9.1 versions

[cornhundred]

Hi, an example notebook by @Pessimistress on ObservableHQ no longer works using the latest version of deck.gl (v9.0.11). The error occurs with the custom scatterplot layer

layer2 = {
  const {Layer} = deck;
  
  class ScatterplotLayer extends Layer {
    initializeState() {
      const {gl} = this.context;

      // Register attributes
      this.getAttributeManager().addInstanced({
        instancePositions: {
          size: 3,
          type: gl.DOUBLE,
          accessor: 'getPosition'
        },
        instanceRadius: {
          size: 1,
          accessor: 'getRadius',
          defaultValue: 1
        },
        instanceColors: {
          size: 4,
          normalized: true,
          type: gl.UNSIGNED_BYTE,
          accessor: 'getColor',
          defaultValue: [0, 0, 0, 255]
        }
      });
      
      // Save the model in layer state
      this.setState({
        model: getModel(gl)
      });
    }
    
    updateState() {
      // Retrieve the model from layer state
      this.state.model.setUniforms({
        smoothRadius: this.props.smoothRadius
      });
    }
  }
  ScatterplotLayer.layerName = 'ScatterplotLayer';
  ScatterplotLayer.defaultProps = defaultProps;

  const layer = new ScatterplotLayer({
    id: `scatterplot-${Date.now()}`,
    data,
    getPosition: d => d.position,
    getRadius: d => d.size,
    getColor: d => d.color
  });
  
  deckgl.setProps({layers: [layer]});
  
  return layer;
}

and the console log shows the following:

dist.min.js:1708 deck: initialization of ScatterplotLayer({id: 'scatterplot-1714329967844'}): 5121 Error: 5121
    at rl (dist.min.js:106:14009)
    at yP (dist.min.js:1708:58162)
    at new su (dist.min.js:1708:59073)
    at new Ji (dist.min.js:1708:65786)
    at qr._createAttribute (dist.min.js:1785:4914)
    at qr._add (dist.min.js:1785:4737)
    at qr.addInstanced (dist.min.js:1785:2917)
    at ScatterplotLayer.initializeState (observablehq-340:11:34)
    at ScatterplotLayer._initialize (dist.min.js:1785:28473)
    at Fn._initializeLayer (dist.min.js:1707:8602)
onError @ dist.min.js:1708
observablehq-340:39 Uncaught TypeError: Cannot read properties of undefined (reading 'setUniforms')
    at ScatterplotLayer.updateState (observablehq-340:39:24)
    at ScatterplotLayer._update (dist.min.js:1785:29213)
    at ScatterplotLayer.activateViewport (dist.min.js:1785:25065)
    at zl._shouldDrawLayer (dist.min.js:1676:3828)
    at zl._getDrawLayerParams (dist.min.js:1676:2317)
    at zl._drawLayers (dist.min.js:1676:1853)
    at zl.render (dist.min.js:1676:1597)
    at Dn.renderLayers (dist.min.js:1707:36619)
    at Vf._drawLayers (dist.min.js:1708:56124)
    at Vf._drawLayers (dist.min.js:3880:37160)

This notebook works with a previous version of deck.gl (v8.9.1 - see fork of notebook)

[Pessimistress]

I've downgraded the dependency to v8 for now. I need to make new examples for v9.

v9 contains various breaking changes in how it interacts with the WebGL API. You can read about them here.

[cornhundred]

Thanks!