ignore custom resource with negtive quantity #92

weiyuanke · 2023-09-28T05:12:53Z

cwdsuzhou · 2023-10-07T02:50:44Z

pkg/common/resource.go

@@ -139,6 +139,9 @@ func (r *Resource) SetCapacityToNode(node *corev1.Node) {
 		corev1.ResourceEphemeralStorage: empStorage,
 	}
 	for name, quota := range r.Custom {
+		if quota.Sign() < 0 {
+			continue
+		}


I am not sure if add this logic will lead to some unexpected issues, e.g. evicting pods. Can you add some test for these scenes?

or, we can simply set the quantity to 0? since kubernetes cannot accept negtive values.

ignore custom resource with negtive quantity

c066492

cwdsuzhou reviewed Oct 7, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ignore custom resource with negtive quantity #92

ignore custom resource with negtive quantity #92

weiyuanke commented Sep 28, 2023 •

edited

cwdsuzhou Oct 7, 2023

weiyuanke Oct 7, 2023

ignore custom resource with negtive quantity #92

Are you sure you want to change the base?

ignore custom resource with negtive quantity #92

Conversation

weiyuanke commented Sep 28, 2023 • edited

cwdsuzhou Oct 7, 2023

Choose a reason for hiding this comment

weiyuanke Oct 7, 2023

Choose a reason for hiding this comment

weiyuanke commented Sep 28, 2023 •

edited