Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying a TCP port results in InvalidImageRegistryServer #573

Open
CVanF5 opened this issue Sep 18, 2023 · 0 comments
Open

Specifying a TCP port results in InvalidImageRegistryServer #573

CVanF5 opened this issue Sep 18, 2023 · 0 comments

Comments

@CVanF5
Copy link

CVanF5 commented Sep 18, 2023

Describe the Issue

Creating an imagePullSecret while specifying a port number results in an incorrect message about the protocol not being supported.

Steps To Reproduce
Create a dockerconfigjson secret with a hostname and a port. Example gitlab.com:443

Result

      RESPONSE 400: 400 Bad Request
      ERROR CODE: InvalidImageRegistryServer
      --------------------------------------------------------------------------------
      {
        "error": {
          "code": "InvalidImageRegistryServer",
          "message": "The server 'gitlab.com:443' in the 'imageRegistryCredentials' of container group 'nginx-k8s-virtual-amd64-small-runner-runner-qihb8krj-project-33599309-concurrent-0-ismfnyon' is invalid. It should be a valid host name without protocol."
        }
      }

Expected behavior
Virtual kubelet pulls an from the specified registry using the specified port

Virtual-kubelet version
v1.25.0-vk-azure-aci-1.6.0
Kubernetes version
1.26.6

Additional context

The message isn't correct, I am not specifying a protocol, I'm specifying a port which is supported by Docker and Kubernetes. It should be supported by virtual-kubelet as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant