Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle proper source verification #21

Open
bastelfreak opened this issue Jan 22, 2016 · 5 comments
Open

Handle proper source verification #21

bastelfreak opened this issue Jan 22, 2016 · 5 comments

Comments

@bastelfreak
Copy link
Member

Would need $magic to validate that a client can only download/delete his installimage config and nothing else.

@bastelfreak
Copy link
Member Author

two proposals:

  • safe the client IP in the config, validate actual client IP against the one in the config
  • create a OTP for a node + attach it to the cmdline
  1. breaks with private IPs /private networking because this can result in duplicate ones
  2. this ties the installimage endpoint to PXE entries, we wanted to avoid that

@killermoehre
Copy link

Am 22. Januar 2016 09:34:36 MEZ, schrieb Tim Meusel notifications@github.com:

Would need $magic to validate that a client can only download/delete
his installimage config and nothing else.

I think this security should be done by the firewall like it's done for DOCSIS in the KabelDeutschland network (someone talked about this at the 32c3; video available).

@bastelfreak
Copy link
Member Author

@killermoehre
how do you want to firewall that? you can do some layer7 filtering and match the requested URI
vs the src IP or any submitted token, but all nodes need to reach the central server.

@bastelfreak
Copy link
Member Author

@pbyatshon what you do think about using the provided UID for authentication? We already use it for the installstatus endpoint.

@bastelfreak
Copy link
Member Author

I'm currently not really sure where we actually delete the config. AFAIK installimage only downloads the config, but we never delete it there. https://github.com/virtapi/LARS/blob/master/scripts/start_installimage#L35


Does an external service (crumb) handle this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants