Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Update Google dependencies? #320

Open
4 tasks done
cristianoccazinsp opened this issue Nov 12, 2019 · 8 comments
Open
4 tasks done

iOS - Update Google dependencies? #320

cristianoccazinsp opened this issue Nov 12, 2019 · 8 comments

Comments

@cristianoccazinsp
Copy link

Environment

Please provide the following information about your environment:

  1. OS: Mac
  2. Version: ViroCore version - The one used by react-viro 2.17
  3. Device(s): iPhone

Description

Hello, opening this issue as a follow up from viromedia/viro#718

Apple is rejecting apps that use UIWebView, and right now it seems like react-viro, which uses viro core, is referencing UIWebView somewhere.
Someone hinted that the references come from google's SDK, can those be updated? Can we get some help to remove any UIWebView reference?

Thanks.

Reproducible Demo

@mstrokin
Copy link

mstrokin commented Dec 20, 2019

@dthian If it's not possible to update the google SDK, is it possible to 'deprecate' the ViroViewGVR and other files related to GVR, thus dropping the support for stereo VR headsets, but still keeping the AR intact?

@Hless
Copy link

Hless commented Dec 25, 2019

From what I understand we should replace the GVRSDK library with the new open source Cardboard library, which no longer contains references to UIWebView. They also appear to have some new features/fixes on the roadmap for that new library

@nickarora
Copy link

Bumping this; this is critical to any app that plans to use this in production. Submissions to the AppStore will soon all be rejected because of the reference to UIWebView. @dthian is there a plan to update the library?

@dthian
Copy link
Member

dthian commented Feb 6, 2020

@nickarora ViroMedia has no active roadmap or plans at the moment. However, as ViroCore is now open sourced (the build instructions are laid out within the ReadMe), please feel free to make the necessary changes if need be.

If i've time, I might take a peak into this issue this weekend.

@TwR-Slice
Copy link

any news on this issue? would it be possible to remove GVR without loosing AR supprt?

@brascene
Copy link

@nickarora exactly, we're currently in phase of submiting the app, and the timing couldn't be worse, and also our hands are tied to make any changes.. any ideas how could we replace GVRSDK?

@Jackyaung
Copy link

I am facing the same problem, any solution ?

@ktemby
Copy link

ktemby commented Jun 10, 2020

I was able to get through the UIWebView issue in my RN 0.62.2 project last night - details here viromedia/viro#852 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants