Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HasPermissionsMixin no multiple permission support in required_permission #126

Open
suryaajha opened this issue Nov 17, 2020 · 1 comment

Comments

@suryaajha
Copy link

suryaajha commented Nov 17, 2020

After going through some source I figured out that we are not supporting checking multiple permissions in required_permission of HasPermissionsMixin.
However, the name suggests it should support since it has plural "permissions" (maybe it's coming in the future?)
However we do support multiple roles checking in HasRoleMixin, It would be a great addition if we start supporting multiple permissions like Django permission_required attribute in PermissionRequiredMixin

@filipeximenes
Copy link
Contributor

Cool, that does makes sense. One caveat is to decide [and make clear to developers] on how it will work. Eg:

  • view requires permission1 AND permission2
  • view requires permission1 OR permission2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants