Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] size to get a random int shouldn't be static i.e. 324 #1845

Open
thisisamank opened this issue Oct 1, 2021 · 4 comments
Open

[bug] size to get a random int shouldn't be static i.e. 324 #1845

thisisamank opened this issue Oct 1, 2021 · 4 comments

Comments

@thisisamank
Copy link

The size to fetch a random int at line 11 and 16 of index.js is static please fix this.

@welcome
Copy link

welcome bot commented Oct 1, 2021

Thanks for opening this issue! 🤗
Wishing you a great Hacktoberfest 2020 🙌 🎉 ⚡️
Are you looking for beginner-friendly issues? Check out this repo.

Hacktoberfest2020

📢 Spread the word about @vinitshahdeo/Hacktoberfest2021 repo across your social media channels to help get others involved! Know out the community-led initiative to mentor beginners for Hacktoberfest'21 here.

Open Source Love

Check out few other repos below 🚀

PortScanner
SimpleBio
HBD
Map Of India

Show some ❤️

  • Consider leaving a ⭐ here.
  • Check out more beginner-friendly repos here.
  • Follow @vinitshahdeo for more updates.
  • Read my open-source journey here.

Say Hi on Twitter! 👋

Twitter Follow

@danielphilipjohnson
Copy link

I'm about to push a fix for this if its okay :)

@Gourab-18
Copy link

I have fixed this bug. You can have a look at it and give feedback.

@danielphilipjohnson
Copy link

I'm about to push a fix for this if its okay :)

I’ve resolved the issue and made sure the index doesn’t go out of bounds. By subtracting -1 from the length

#1853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants