Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An Improve of the demo.html page #244

Closed
wants to merge 2 commits into from
Closed

An Improve of the demo.html page #244

wants to merge 2 commits into from

Conversation

enyichiaagu
Copy link

@enyichiaagu enyichiaagu commented May 4, 2020 •
edited

Description

I'm so excited to contribute to this project
Fixes #243
I added basic styling to the demo.html page. I also changed home.html to Index.html, and added the logo as the favicon

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

iot

Reviewer: Vinit Shahdeo

@welcome
Copy link

welcome bot commented May 4, 2020

Thanks for opening this pull request!
Please add @vinitshahdeo as a reviewer if you haven't added.

@auto-assign auto-assign bot requested a review from vinitshahdeo May 4, 2020 03:28
@enyichiaagu
Copy link
Author

@vinitshahdeo

PragatiVerma18
PragatiVerma18 suggested changes May 9, 2020
View reviewed changes
Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't unnecessary changes to the codebase or else explain properly in your PR whatever you're trying to implement.

@PragatiVerma18
Copy link
Contributor

@enyichiaagu We are not accepting any changes to the master branch. Please make contributions as per the instructions in the readme:

  • If you're interested in contributing for documentation, please check out feature/documentation branch.

  • If you're interested in contributing for backend, please check out the following branch according to the tech stack:

  • Django: feature/backend-django

  • Node.js: feature/backend-node

  • If you're interested in contributing for frontend, please check out feature/frontend branch.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragatiVerma18 PragatiVerma18 PragatiVerma18 requested changes

@vinitshahdeo vinitshahdeo Awaiting requested review from vinitshahdeo

Assignees

@vinitshahdeo vinitshahdeo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Would like to style demo.html
3 participants
@enyichiaagu @PragatiVerma18 @vinitshahdeo