Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSVReader doesn't conform to the C++20 input_range concept #191

Open
pratzl opened this issue Jan 9, 2022 · 2 comments
Open

CSVReader doesn't conform to the C++20 input_range concept #191

pratzl opened this issue Jan 9, 2022 · 2 comments
Assignees

Comments

@pratzl
Copy link

pratzl commented Jan 9, 2022

When working in C++20 I am accepting a range for my template function (really a constructor). When I specify the std::range::input_range concept for the parameter the function isn't visible and I can't use it. Reverting input_range back to typename will work, but I'd like to be able to use concepts.

When looking at the definition of CSVReader I see there are some types that aren't defined that could be causing this, such as const_iterator, const_reference, and const_pointer. There may be other issues also.

I'm working on a graph library prototype for the standard library and it would be useful to have this (paper P1709). If I have time, I might try to fork it and make some changes but I have a lot of other priorities right now.

@vincentlaucsb
Copy link
Owner

Could be a nice addition. This library was created before C++20 was standardized.

@sangoblin
Copy link

DO you plan to keep maintaining this library and upgrade it to conform with C++20 or even C++23? Thanks.

@vincentlaucsb vincentlaucsb self-assigned this Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants