fix: Update tests for Async.Promise .wait #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsuyoshicho
force-pushed
the
fix/update-asyncwait
branch
from
c04319d
to
4517cb6
Compare
tsuyoshicho
force-pushed
the
fix/update-asyncwait
branch
from
f7f8a9d
to
2e3e418
Compare
tsuyoshicho
changed the title
ujihisa
reviewed
Mar 16, 2024
ujihisa
reviewed
Mar 16, 2024
ujihisa
reviewed
Mar 16, 2024
ujihisa
reviewed
Mar 16, 2024
Co-authored-by: ujihisa <ujihisa@users.noreply.github.com>
Apply similar change to other comments. Co-authored-by: ujihisa <ujihisa@users.noreply.github.com>
|
英語が雑なところありました、修正指摘ありがとうございます @ujihisa |
ujihisa
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #809
Update Async.Promise .wait test:
他のテストとの兼ね合いはありそうですが、現在わかってる範囲で改善を行いました。
全体としてもうすこし細かく確認を分割したほうがいい気はしますね。
macについては、アンダーフロー、オーバーフローのどちらも出たので、精度的な問題として暫定で範囲を広げて対応しています。
ここを見そうな方を暫定でreviewer指定しています