Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When non-current files have the current file's first handler non-first, "Handlers of selected files are incompatible." #911

Open
aleksejrs opened this issue Jun 17, 2023 · 2 comments

Comments

@aleksejrs
Copy link
Contributor

aleksejrs commented Jun 17, 2023

All files in question have handler x %f first in the list.
One file has another handler first in its list, and x %f second.

Select all those files and press Enter or .

Result: "Handlers of selected files are incompatible."
Expected result: use the first handler of the current file, because it is present in the list of handlers for the "unusual" file. See also #177 (comment)

Pressing c on the handlers seems to result in the same string.

Vifm 0.13

@aleksejrs
Copy link
Contributor Author

I am not sure it's a good idea to just run it, but maybe Vifm should open the menu in that case.

@xaizek
Copy link
Member

xaizek commented Jun 18, 2023

In the linked comment:

  • When all files are handled by the same program which uses %f macro, it's invoked.

Means "handled by the same program if you open each file individually" as opposed to "can be handled by the same program". There is no search among handlers, the first one available for each file gets used.

Your interpretation that handler of the current file should be looked up among handlers of the other files makes sense.

I wouldn't start a menu because this case doesn't stand out much compared to others. Maybe one day 'confirm' will have a value for running files and this can be one of the cases to confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants