Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove factory and store provider on providers list #56

Open
flavioribeiro opened this issue Apr 5, 2016 · 2 comments
Open

remove factory and store provider on providers list #56

flavioribeiro opened this issue Apr 5, 2016 · 2 comments

Comments

@flavioribeiro
Copy link
Member

I've discussed with @fsouza about that, maybe storing the provider directly on providers list will reduce the overall complexity of the code. We should remove the factory and create a Validate() to be used on init().

@fsouza
Copy link
Collaborator

fsouza commented Apr 5, 2016

An important side effect of this change is that we would no longer support configuration files, only environment variables, because packages all inits are called before main, and we read the path and parse the config file in main.

We currently use environment variables, and it is indeed an approach that I prefer, so I'm +1 for this change.

It's worth mentioning that we're breaking the Gizmo way of handling configuration, but that's actually a good thing.

@fsouza
Copy link
Collaborator

fsouza commented Aug 8, 2016

We recently dropped support for file-based configuration in our APIs, so this is no longer a question.

@fsouza fsouza removed the question label Aug 8, 2016
@flavioribeiro flavioribeiro changed the title Remove factory and store provider on providers list remove factory and store provider on providers list Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants