Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHttpServer and PFtpServer won't be stopped #131

Open
notEvil opened this issue Jan 4, 2023 · 0 comments
Open

PHttpServer and PFtpServer won't be stopped #131

notEvil opened this issue Jan 4, 2023 · 0 comments

Comments

@notEvil
Copy link

notEvil commented Jan 4, 2023

Hi,

PHttpServer is added to whatIsRunning but doesn't have a __stop method. PFtpServer is not added to whatIsRunning in the first place.

The server classes are pretty different in this regard (maybe use WhatIsRunningInterface, maybe extend ProtoBase which has its own abstract __stop, ...).
@notEvil notEvil mentioned this issue Jan 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@notEvil