Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining an empty variable name makes a module inaccessible #21

Open
shockey opened this issue Aug 22, 2016 · 1 comment
Open

Defining an empty variable name makes a module inaccessible #21

shockey opened this issue Aug 22, 2016 · 1 comment
Labels

Comments

@shockey
Copy link
Collaborator

shockey commented Aug 22, 2016

Example:

→ trymodule js-yaml=
Gonna start a REPL with packages installed and loaded for you
Couldn't find 'js-yaml' locally, gonna download it now
js-yaml@3.6.1 .trymodule/node_modules/js-yaml
├── esprima@2.7.2
└── argparse@1.0.7 (sprintf-js@1.0.3)
Package 'js-yaml' was loaded and assigned to '' in the current scope
REPL started...
>

This was a typo on my part, and strictly speaking, it isn't a bug... but it definitely would have been a nice user experience for trymodule to have picked up on my mistake and defaulted to the module's name.

Thoughts?

@victorb
Copy link
Owner

victorb commented Jan 21, 2017

Agreed, should default to the modules name as if you omitted the equal sign completely.

@victorb victorb added the bug label Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants