Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider using colors #16

Open
victorb opened this issue Mar 29, 2016 · 6 comments
Open

Reconsider using colors #16

victorb opened this issue Mar 29, 2016 · 6 comments

Comments

@victorb
Copy link
Owner

victorb commented Mar 29, 2016

https://github.com/VictorBjelkholm/trymodule/blob/2030806d790213d426456959fdc7a69773a4c6f7/index.js#L5

You might want to reconsider using colors. It's a bad unmaintained module from a user-hostile author. Check out cli-colors or chalk instead.

From: sindresorhus/awesome-nodejs#477 (comment)

@dthree
Copy link

dthree commented Mar 29, 2016

Chalk FTW

@victorb
Copy link
Owner Author

victorb commented Apr 1, 2016

So, I've checked out both cli-color and chalk. Both seems good but introduces many dependencies compared to colors. One reason why colors have been my go-to module when it comes to colors in the terminal, is because of the simplicity and zero dependencies.

So unless someone else can recommend another zero dependency module instead of colors, I'll close this and live with colors.

@dthree
Copy link

dthree commented Apr 2, 2016

@victorbjelkholm all of Chalk's deps are maintained by the same author, and are like 7kb or less. Not a biggie.

I would consider extending the String prototype a much more concerning proposition than a few tiny deps by the same (trusted) author.

@victorb
Copy link
Owner Author

victorb commented Apr 2, 2016

The network requests are the overhead really, and I would prefer to have a small number of tiny dependencies rather that a big number of them

Yeah, I'm not relying on any of the String prototype stuff that colors provide, although it does seem like I'm missusing it, and should use require('colors/safe') instead of just require('colors'). https://github.com/Marak/colors.js/blob/master/lib/index.js#L8

@dthree
Copy link

dthree commented Apr 2, 2016

Okay, cool. Up to you, man. But thats my two cents. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@victorb @dthree and others