New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exec call to remove cache folder #15

Open

victorb opened this issue Mar 29, 2016 · 0 comments

Labels

enhancement help wanted

Owner

victorb commented Mar 29, 2016

https://github.com/VictorBjelkholm/trymodule/blob/2030806d790213d426456959fdc7a69773a4c6f7/index.js#L59

Oh noes. Please don't. Never do string concat for commands, use execFile instead. Never pass environment variables directly to rm without sanitation, better yet, never spawn rm. Use a JS tools, like rimraf or even better del.

From: sindresorhus/awesome-nodejs#477 (comment)

victorb added enhancement help wanted labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment