Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition to F-Droid #3

Open
HenriDellal opened this issue Jul 16, 2018 · 5 comments
Open

Addition to F-Droid #3

HenriDellal opened this issue Jul 16, 2018 · 5 comments

Comments

@HenriDellal
Copy link

HenriDellal commented Jul 16, 2018

Hello.
Please could you submit this app to F-Droid? Many open source enthusiasts use it, so you may encourage them to learn Kotlin and write apps on it.
Thank you for the app.

@vickychijwani
Copy link
Owner

Hi @HenriDellal! 👋

Thanks for reaching out. Unfortunately I'm extremely short on time these days so I won't be able to do this. You might say "it will only take an hour", but it's never just an hour. There's also the time spent updating the app on F-Droid in addition to Google Play every time there's a new release, not to mention the associated cognitive load.

Moreover, this app has only a few hundred users, of which there won't be more than 2-3% using F-Droid, so I can't justify the time investment for myself.

I'll close this issue now, but feel free to take this up yourself if you're interested and I'll re-open it in that case. I may be able to help if you have some questions regarding that.

@HenriDellal
Copy link
Author

Thank you. I've submitted an addition request, so hopefully it will be added soon. Also, you don't have to worry about the updates, as F-Droid automatically builds every release.

@HenriDellal
Copy link
Author

HenriDellal commented Jul 26, 2018

It appears that it requires gradle distribution checksum set in gradle.properties for security reasons.
There is an example:

distributionUrl=https\://services.gradle.org/distributions/gradle-4.2.1-all.zip
distributionSha256Sum=7897b59fb45148cd8a79f078e5e4cef3861a252dd1a1af729d0c6e8a0a8703a8

All distributions and their checksums are listed at https://services.gradle.org/distributions . I can add these myself if you want, just tell me the version please. It is also recommended to add F-Droid build flavour without firebase, crashlytics and google parts. I may try to write it as I have some free time.

@vickychijwani vickychijwani reopened this Jul 26, 2018
@vickychijwani
Copy link
Owner

The gradle version is 4.1, you can see it here: https://github.com/vickychijwani/kotlin-koans-android/blob/master/gradle/wrapper/gradle-wrapper.properties

I'm happy to accept a PR with the checksum change and appreciate the effort you're putting into this 🙂

@vickychijwani
Copy link
Owner

vickychijwani commented Jul 26, 2018

In the fdroid flavor, feel free to drop the firebase and crashlytics dependencies altogether (will require some code changes to make the app not crash if they're absent). For the google dependencies, I don't think the app directly depends on gms; it's probably getting pulled in via Firebase or some other dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants