Migrate to InnoDB

[Zankaria]

Vichan still defaults to the ancient MyISAM storage engine which:

• Has no transaction support.
• Has mediocre concurrency support.

The former can be useful to improve the DB structure and data resiliency with foreign key constraints, which can be used to prevent dangling references to messages and posts in the nttpchan table, for example.
The latter I belive to be more of a pressing issue, as it can be very nasty for Vichan's performance. When MyISAM needs to insert a new post in any board table, it locks the whole table, which can easily result in long stalls if any other Vichan PHP processes tries to access it.
InnoDB has no such weakness, as it doesn't lock at table level but at row level, allowing for much higher concurrency.
Higher concurrency could also allow to merge all the board tables into a single table, where each post is identified by an automatically incremented numeric id, allowing to establish a total ordering of all the posts on the instance without having to rely on unix timestamps, which can easily go out of sync and result in data loss (something that has already happened at least once).

[RealAngeleno]

That was something I did in the soyjak.party version of vichan yet never did in vichan itself, because of the differences in code from each place.

[Zankaria]

That was something I did in the soyjak.party version of vichan yet never did in vichan itself, because of the differences in code from each place.

Well, this posits the question then: what are those differences? What needs to be changed?

[RealAngeleno]

probably not much

[Zankaria]

The code you pushed doesn't provide an upgrade path though.
Namely, it doesn't convert existing tables

[RealAngeleno]

big oversight. As I just went ALTER TABLE for everything manually.