Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(beta) Noted bugs that need to be fixed before next vichan stable release #580

Open
RealAngeleno opened this issue Jun 6, 2023 · 2 comments · Fixed by #583
Open

(beta) Noted bugs that need to be fixed before next vichan stable release #580

RealAngeleno opened this issue Jun 6, 2023 · 2 comments · Fixed by #583
Labels

Comments

@RealAngeleno
Copy link

RealAngeleno commented Jun 6, 2023

Leaving all bugs here that need to be fixed before the next vichan stable release. Crossed out means that it was fixed.

  • Dismiss Post works exactly the same as Dismiss+, dismissing all posts by the corresponding IP address.
  • When it comes to reports of a post and its replies, reports for that thread get messed up (duplicated, mismatched, etc). Is fixed by dismissing one of the thread reports. Multiple Reports of Different Posts Causing Report Queue to Show Only Same Post Reported Twice(or more) #567
  • User list causes error with twig.
  • There is no space after the name (e.g. Anonymous06/05/2023 instead of Anonymous 06/05/2023).
  • Rangebans are not functional.
  • AJAX requests when it comes to deleting or reporting posts are not made.
@ogjamesfranco
Copy link

For the spacing issue - it seems to be caused by one of the changes in #553, which replaced all instances of the "remove_whitespace" twig filter with twig's "spaceless" filter. The remove_whitespace filter only removed \t, \r, and \n characters, not spaces (see 427f3f8), whereas I'm guessing twig's spaceless filter also removes space characters. If you try taking out the apply spaceless tags in post_thread.html, the described issue goes away.

I don't mind making a pull request to revert things to the old filter if you'd like, though I'm still familiarizing myself with the project and the frameworks/tools being used, so I'm not terribly confident in changing a ton of files without double-checking things first.

@RealAngeleno
Copy link
Author

RealAngeleno commented Jun 20, 2023

Removing the spaceless filter during such portion is probably the best solution then. Didn't notice any issues since sanitization is already done elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants