Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Deprecations: A thread #546

Open
basedgentoo opened this issue Mar 25, 2023 · 4 comments
Open

PHP Deprecations: A thread #546

basedgentoo opened this issue Mar 25, 2023 · 4 comments

Comments

@basedgentoo
Copy link

I'm going to use this to report PHP deprecation messages/warnings I run into as I tinker with the software on the latest PHP revision.

install.php reports the following with verbose error reporting enabled
Deprecated: Return type of Twig\Node\Node::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/twig/twig/src/Node/Node.php on line 213

Deprecated: Return type of Twig\Node\Node::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/twig/twig/src/Node/Node.php on line 221

Installer still seems to function, but these errors are visible at the top of the page.

@perdedora
Copy link
Member

If you keep upping the php version, twig also has to be updated.

@perdedora
Copy link
Member

perdedora commented Mar 29, 2023

most of this problem was fixed with #553

new deprecations:

@perdedora
Copy link
Member

The securimage can be fixed by changing composer.json to use custom repository

    "repositories": [
	    {
		"type": "vcs",
		"url": "https://github.com/alex300/securimage"
	    }
    ],

@frozenpandaman
Copy link

Here's one more that I don't see mentioned above:

htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /path/to/inc/functions.php on line 2307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants