Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal to merge with vibrationtesting #94

Open
bagustris opened this issue Sep 8, 2022 · 1 comment
Open

proposal to merge with vibrationtesting #94

bagustris opened this issue Sep 8, 2022 · 1 comment

Comments

@bagustris
Copy link
Contributor

bagustris commented Sep 8, 2022

Dear @josephcslater,

Due to low activity in this repository, I would like to propose to merge this repository
with vibrationtesting.

I still use both to teach vibration courses; instead of installing separate packages,
it will be simpler to use one package only (vibrationtoolbox).

Thank you for your great effort.
I hope this project will continue (implementing all concepts in Inman's vibration & control).

@josephcslater
Copy link
Member

I don't see myself doing that for a number of reasons.

  1. The Vibration Toolbox is tied to introductory vibration material. It's designed principally to be an educational tool for an undergraduate level course. If it actually does anything useful, it's minimal. That's a bit different from the testing module.
  2. I have a substantial coauthor for this repository and they haven't contributed to the other, which leads to:
  3. The organization of a merger would be that much more complex and take some rethinking. It's not something I'm interested in.
  4. The purpose of the testing repository is a companion to a manuscript that is about 60% complete. It's cleaner that I keep it separate. I may not finish that manuscript, but the fact that it's all more advance material that is documented in that manuscript distinguishes it.
  5. I'm not specifically implementing anything in Inman's Vibration & Control book. I haven't looked at it since I took the class from him. No offense to him, but the details of the code go deeper into the signal processing, etc., than I recall being in the original text. Perhaps there is more now, but then again, his text and my manuscript have very different objectives.

Dependent packages aren't hard to import from and fuse in an import, but laying them out logically would take time I'd rather spend, if I find it, to implement more Vibration Testing algorithms (ERA, for instance, etc.). I'm not sure I will- I'm a bit busy otherwise, but I have that hope. If you would like to, I would certainly entertain such pull requests. As for Dan's text, if there is something in there you would like in a module, I'm happy to consider if it would make sense in either of these, or if a module for that text should be started (though I am not volunteering for that effort).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants