Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing Container Resources Without Restarting Containers #803

Open
Lightxyz opened this issue Sep 6, 2023 · 4 comments
Open

Resizing Container Resources Without Restarting Containers #803

Lightxyz opened this issue Sep 6, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@Lightxyz
Copy link
Contributor

Lightxyz commented Sep 6, 2023

Is your feature request related to a problem? Please describe.
Cannot change CPU requests / limits for pods / containers which are running, without restarting them.

Describe the solution you'd like
An upgrade to Kubernetes version 1.27 would allow us to resize CPU and memory resources assigned to containers without needing to restart them. See the following:
https://kubernetes.io/docs/tasks/configure-pod-container/resize-container-resources/
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.27.md#changelog-since-v1260
"PodSpec.Container.Resources became mutable for CPU and memory resource types."

Describe alternatives you've considered
Editing the cpu.shares and the cpu.cfs_quota_us files enables us to adjust the CPU request and the CPU limit while the container is running, but this may interfere with the Kubernetes scheduler.
EDIT:
The kn service update command can adjust CPU requests / limit and memory requests of pods, but it's unclear whether it will adjust the CPU share that existing pods which are currently processing invocations get.

@leokondrashov leokondrashov added the enhancement New feature or request label Sep 6, 2023
@ustiugov
Copy link
Member

ustiugov commented Sep 8, 2023

@Lightxyz I don't mind as it seems that Knative folks are moving to 1.25 version since knative 1.11 (we have 1.9) as the minimum required (we have 1.25 now) so it would be good to move forward.

@Lightxyz can you take the lead on this upgrade?

@Lightxyz
Copy link
Contributor Author

Lightxyz commented Sep 8, 2023

@Lightxyz I don't mind as it seems that Knative folks are moving to 1.25 version since knative 1.11 (we have 1.9) as the minimum required (we have 1.25 now) so it would be good to move forward.

@Lightxyz can you take the lead on this upgrade?

Great, what's the status on migrating the changes from the hy branch into main?
I could then work on upgrading Kubernetes and Knative in the main branch.

@ustiugov
Copy link
Member

ustiugov commented Sep 10, 2023

you can focus on the main branch without any delay, it's already ahead of hy. the plan is that a new visiting student of ours will take the hy migration over in the beginning of October

@Lightxyz
Copy link
Contributor Author

you can focus on the main branch without any delay, it's already ahead of hy. the plan is that a new visiting student of ours will take the hy migration over in the beginning of October

Sounds good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants