Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Improve lyrics search engine #37

Open
ChristophyBarth opened this issue Apr 18, 2019 · 5 comments
Open

Improve lyrics search engine #37

ChristophyBarth opened this issue Apr 18, 2019 · 5 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@ChristophyBarth
Copy link

Expected behavior

  • I expected the lyrics of any music I played to be displayed so I could sing along with the flow of the music.

Actual behavior

  • Once I click on the 'lyrics' option, no lyric is displayed. Except for a feedback that said “Song lyric not found. Sorry...” or “Error occurred while parsing lyrics.”

How to reproduce

  • Download and install the latest version of the Blade Player.
  • Launch the application
  • Start playing a music
  • Click on the music (at the bottom of your screen) which has started playing
  • Click on the three vertically arranged dots around the bottom of the screen
  • Then click on the 'Lyrics' option
  • See error

  • App version: 1.4.0.1
  • Device: Gionee f100s
  • Operating system: android version 6.0

Recording of the bug

@vhaudiquet
Copy link
Owner

To find the lyrics of a song, Blade uses it's metadata : song title, album, and artist. I see on the recording that your song does not seem to have the accurate metadata. Imagine searching the lyrics for "Statement NF Lyrics 128K MP3 by Unknown Artist in SnaptubeAudio album" in a database : you would get not result. Well that's basically what Blade does. In order for this feature to work, you need to set metadata accurately.

@ChristophyBarth
Copy link
Author

I have tried it even with 5 different musics but the lyrics won't show.

@ChristophyBarth
Copy link
Author

Just now, I tried playing another song by NF titled WHY.
Even with the right information's,
20190418-200226

here's the result I got 👇
20190418-200209
.
.
.
Other music players would use this information to get the lyrics (I'm sure because I did it lately with another app)

@ChristophyBarth
Copy link
Author

@valou3433, will you do anything about this? Please

@vhaudiquet
Copy link
Owner

Alright, i'm gonna try to improve the lyrics searching engine, but this might be really tricky because i would need partnerships with lyrics providers...
For now i'm using Genius API and doing a little magic (which sometimes fail, hence the "lyrics parsing error") to get lyrics. Maybe another API could be better ?
Anyway, i'll look into it.

@vhaudiquet vhaudiquet added bug Something isn't working enhancement New feature or request labels Apr 20, 2019
@vhaudiquet vhaudiquet self-assigned this Apr 20, 2019
@vhaudiquet vhaudiquet changed the title [Blade player version 1.4.0.1] App does not show music lyrics Improve lyrics search engine Apr 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants