Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider clang-format and clang-tidy support #30

Open
alexrp opened this issue Jul 14, 2021 · 2 comments
Open

Consider clang-format and clang-tidy support #30

alexrp opened this issue Jul 14, 2021 · 2 comments
Labels
area: documentation Issues related to the documentation. area: samples Issues related to sample projects. area: sdk Issues related to the MSBuild SDK. area: tasks Issues related to MSBuild tasks. state: deliberation Issues that require considerable deliberation and/or discussion before a resolution can be found. type: feature Issues that are classified as feature requests.
Milestone

Comments

@alexrp
Copy link
Sponsor Member

alexrp commented Jul 14, 2021

In a similar vein to:

Unfortunately, Zig does not currently ship with these tools, so we would have to require users to install them.

Questions:

  • Should we mandate a specific code style like zig fmt or let it be configurable?
  • Should we try to detect the presence of these tools on disk or just go ahead and invoke them if the user asked us to?
  • Should clang-tidy be tied to WarningLevel? Or should we maybe use AnalysisLevel/AnalysisMode?
@alexrp alexrp added type: feature Issues that are classified as feature requests. state: deliberation Issues that require considerable deliberation and/or discussion before a resolution can be found. area: documentation Issues related to the documentation. area: sdk Issues related to the MSBuild SDK. area: samples Issues related to sample projects. area: tasks Issues related to MSBuild tasks. labels Jul 14, 2021
@alexrp alexrp added this to the v4.0 milestone Jul 14, 2021
@alexrp alexrp self-assigned this Jul 14, 2021
@alexrp
Copy link
Sponsor Member Author

alexrp commented Jul 14, 2021

For CI, we'd need to use: https://github.com/KyleMayes/install-llvm-action

@alexrp
Copy link
Sponsor Member Author

alexrp commented Jul 24, 2021

  • Code style: There's too much variation in the C/C++ world. Better to let it be configurable.
  • Tool detection: There's virtually no precedent for doing this in the MSBuild world, so I think users would find it surprising. We should just invoke the tools if asked to and error out appropriately if they're missing.

Need to think more about where clang-tidy integration would fit in.

@alexrp alexrp modified the milestones: v4.0, v5.0 Oct 30, 2022
@alexrp alexrp modified the milestones: v5.0, Future Jan 1, 2024
@alexrp alexrp removed their assignment Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation Issues related to the documentation. area: samples Issues related to sample projects. area: sdk Issues related to the MSBuild SDK. area: tasks Issues related to MSBuild tasks. state: deliberation Issues that require considerable deliberation and/or discussion before a resolution can be found. type: feature Issues that are classified as feature requests.
Development

No branches or pull requests

1 participant