Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Veryl doesn't emit package_scope #692

Closed
nananapo opened this issue Apr 28, 2024 · 1 comment · Fixed by #737
Closed

Veryl doesn't emit package_scope #692

nananapo opened this issue Apr 28, 2024 · 1 comment · Fixed by #737
Labels
bug Something isn't working

Comments

@nananapo
Copy link
Contributor

nananapo commented Apr 28, 2024

config.veryl

package config {
    local XLEN: u32 = 32;
}

eei.veryl

package eei {
    local XLEN: u32 = config::XLEN;
}

eei.veryl is translated into

package core_eei;
    localparam int unsigned XLEN = XLEN;
endpackage

Veryl doesn't emit package scope when package parameter refers another same name package value.

@dalance dalance added the bug Something isn't working label Apr 30, 2024
dalance added a commit that referenced this issue May 27, 2024
@dalance
Copy link
Collaborator

dalance commented May 27, 2024

This issue was fixed at #726 which changes visibility detection mechanism of emitter.

dalance added a commit that referenced this issue May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants