Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics code prevents building after cloning #6

Open
SpacyRicochet opened this issue Oct 20, 2020 · 2 comments
Open

Analytics code prevents building after cloning #6

SpacyRicochet opened this issue Oct 20, 2020 · 2 comments

Comments

@SpacyRicochet
Copy link
Contributor

After cloning the project, it's not possible to build it yet. The analytics code causes compiler errors, because the AWS frameworks are not included.

It's probably better to add some kind of dependency management so new contributors can more easily contribute.

Workaround:

  • Remove AWSFrameworks from the 'Embed Frameworks' build phase.
  • Comment out script in the the Pinpoint Hocus Pocus build phase.
  • Remove awsconfiguration.json from being copied in the Copy Resources build phase.
  • Comment out import AWSPinpoint and all the contents of the methods in AWSAnalyticsService.swift.
@vermont42
Copy link
Owner

I agree that dependency management is the correct solution. In my defense, the app has had no external contributors for the three years of its existence, though there may soon be one. 😅

As a stopgap, would you like to PR the readme with the workaround?

@SpacyRicochet
Copy link
Contributor Author

Sure, that makes sense. I didn't expect this to be a very contributed to project either ;) But it's a fun one to learn some new accessibility features on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants