Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong result for path rewriting with dot inside #133

Open
e-cloud opened this issue Sep 27, 2020 · 1 comment
Open

Wrong result for path rewriting with dot inside #133

e-cloud opened this issue Sep 27, 2020 · 1 comment

Comments

@e-cloud
Copy link

e-cloud commented Sep 27, 2020

For example,

/version/8.5.x/

will be recognized as a file.

This is a known issue.

This line of code should not use path.extname to test a path

https://github.com/vercel/serve-handler/blob/master/src/index.js#L608
@favoyang favoyang mentioned this issue Oct 1, 2020
Open
@warren-bank
Copy link

shameless self-promotion alert:
this feature is fixed in my @warren-bank/serve fork of serve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@e-cloud @warren-bank