Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve global next Webpack alias last #65123

Merged
merged 2 commits into from Apr 30, 2024
Merged

Resolve global next Webpack alias last #65123

merged 2 commits into from Apr 30, 2024

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 27, 2024

Currently it takes precedence over any potential subsequent alias of next/* e.g. aliasing next/dist/compiled/react to react.react-server. Moving it to the last position still ensures next/* is aliased while also allowing aliasing next/dist/compiled/react which we'll need for #65058

Closes NEXT-3249

It would take precedence over any potential subsequent alias of `next/*` e.g. aliasing `next/dist/compiled/react` to react.react-server
@ijjk
Copy link
Member

ijjk commented Apr 27, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Apr 27, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js sebbie/no-next-alias Change
buildDuration 18.8s 17.5s N/A
buildDurationCached 10.1s 8.5s N/A
nodeModulesSize 360 MB 360 MB ⚠️ +1.28 kB
nextStartRea..uration (ms) 469ms 465ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/no-next-alias Change
1103-HASH.js gzip 31.8 kB 31.8 kB N/A
1a9f679d-HASH.js gzip 53.5 kB 53.5 kB N/A
335-HASH.js gzip 5.09 kB 5.09 kB N/A
7953.HASH.js gzip 169 B 169 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 229 B 229 B
main-HASH.js gzip 31.5 kB 31.5 kB N/A
webpack-HASH.js gzip 1.65 kB 1.65 kB N/A
Overall change 45.6 kB 45.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/no-next-alias Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js sebbie/no-next-alias Change
_app-HASH.js gzip 192 B 193 B N/A
_error-HASH.js gzip 192 B 193 B N/A
amp-HASH.js gzip 507 B 511 B N/A
css-HASH.js gzip 341 B 343 B N/A
dynamic-HASH.js gzip 2.52 kB 2.52 kB
edge-ssr-HASH.js gzip 266 B 265 B N/A
head-HASH.js gzip 362 B 365 B N/A
hooks-HASH.js gzip 392 B 392 B
image-HASH.js gzip 4.32 kB 4.32 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.69 kB 2.7 kB N/A
routerDirect..HASH.js gzip 329 B 328 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 324 B 324 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 4 kB 4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/no-next-alias Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/no-next-alias Change
index.html gzip 527 B 527 B
link.html gzip 542 B 541 B N/A
withRouter.html gzip 524 B 524 B
Overall change 1.05 kB 1.05 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/no-next-alias Change
edge-ssr.js gzip 94.7 kB 94.7 kB N/A
page.js gzip 181 kB 181 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sebbie/no-next-alias Change
middleware-b..fest.js gzip 623 B 622 B N/A
middleware-r..fest.js gzip 156 B 156 B
middleware.js gzip 25.7 kB 25.7 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 995 B 995 B
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/no-next-alias Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 98.4 kB 98.4 kB
app-page-tur..prod.js gzip 99.9 kB 99.9 kB
app-page-tur..prod.js gzip 94.3 kB 94.3 kB
app-page.run...dev.js gzip 157 kB 157 kB
app-page.run..prod.js gzip 93 kB 93 kB
app-route-ex...dev.js gzip 21.5 kB 21.5 kB
app-route-ex..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route.ru...dev.js gzip 21.3 kB 21.3 kB
app-route.ru..prod.js gzip 15 kB 15 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 21.5 kB 21.5 kB
pages.runtim...dev.js gzip 22.1 kB 22.1 kB
pages.runtim..prod.js gzip 21.5 kB 21.5 kB
server.runti..prod.js gzip 51.6 kB 51.6 kB
Overall change 962 kB 962 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sebbie/no-next-alias Change
0.pack gzip 1.61 MB 1.62 MB ⚠️ +4.08 kB
index.pack gzip 113 kB 113 kB N/A
Overall change 1.61 MB 1.62 MB ⚠️ +4.08 kB
Diff details
Diff for edge-ssr.js

Diff too large to display

Commit: 55b21d0

@eps1lon eps1lon changed the title Remove global next Webpack alias Resolve global next Webpack alias last Apr 28, 2024
@eps1lon eps1lon marked this pull request as ready for review April 30, 2024 10:58
@eps1lon eps1lon merged commit 2c98c11 into canary Apr 30, 2024
83 checks passed
@eps1lon eps1lon deleted the sebbie/no-next-alias branch April 30, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants