Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating pages/_app.js should not require a dev server restart #13957

Closed
Timer opened this issue Jun 9, 2020 · 5 comments
Closed

Creating pages/_app.js should not require a dev server restart #13957

Timer opened this issue Jun 9, 2020 · 5 comments
Labels
kind: bug Confirmed bug that is on the backlog
Milestone
backlog

Comments

@Timer
Copy link
Member

Timer commented Jun 9, 2020

Bug report

Describe the bug

Creating pages/_app.js currently requires the user reboot their dev server.

To Reproduce

  1. Start a Next.js application without pages/_app.js (next dev).
  2. Create pages/_app.js.
  3. Bug: No Fast Refresh to introduce the App Component.
  4. Refresh the page from server.
  5. Bug: Still no App Component.

Expected behavior

The Next.js dev server should automatically recognize the creation of a custom app and work.
@Timer Timer added good first issue Easy to fix issues, good for newcomers kind: bug Confirmed bug that is on the backlog point: 5 labels Jun 9, 2020
@Timer Timer added this to the backlog milestone Jun 11, 2020
@fsr313
Copy link

fsr313 commented Jun 24, 2020

Can you give some hint on how can we achieve this?

@timneutkens timneutkens removed the good first issue Easy to fix issues, good for newcomers label Jun 24, 2020
@timneutkens
Copy link
Member

Removed good first issue as it's significantly complicated until we have #13341

@fsr313
Copy link

fsr313 commented Jun 24, 2020

understandable, thanks

@timneutkens
Copy link
Member

This is supported in Next.js 12 🎉

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind: bug Confirmed bug that is on the backlog
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
4 participants
@Timer @timneutkens @fsr313 @balazsorban44